synchronize documents generation

app/controllers/send_submission_email_controller.rb

@@ -17,8 +17,6 @@ class SendSubmissionEmailController < ApplicationController
         Submitter.find_by!(slug: params[:submitter_slug])
       end
 
-    Submissions::GenerateResultAttachments.call(@submitter) if @submitter.documents.blank?
-
     SubmitterMailer.documents_copy_email(@submitter).deliver_later!
 
     respond_to do |f|

app/controllers/start_form_controller.rb

@@ -13,7 +13,7 @@ class StartFormController < ApplicationController
 
   def update
     @submitter = Submitter.where(submission: @template.submissions.where(deleted_at: nil))
-                          .find_or_initialize_by(**submitter_params)
+                          .find_or_initialize_by(email: submitter_params[:email])
 
     if @submitter.completed_at?
       redirect_to start_form_completed_path(@template.slug, email: submitter_params[:email])
@@ -25,7 +25,7 @@ class StartFormController < ApplicationController
         ua: request.user_agent
       )
 
-      @submitter.build_submission(template: @template)
+      @submitter.submission ||= Submission.new(template: @template)
 
       if @submitter.save
         redirect_to submit_form_path(@submitter.slug)

app/controllers/submissions_download_controller.rb

@@ -6,7 +6,7 @@ class SubmissionsDownloadController < ApplicationController
   def index
     submitter = Submitter.find_by(slug: params[:submitter_slug])
 
-    Submissions::GenerateResultAttachments.call(submitter) if submitter.documents.blank?
+    Submissions::EnsureResultGenerated.call(submitter)
 
     urls =
       Submitters.select_attachments_for_download(submitter).map do |attachment|

app/controllers/submit_form_controller.rb

@@ -24,6 +24,8 @@ class SubmitFormController < ApplicationController
     submitter.save!
 
     if submitter.completed_at?
+      GenerateSubmitterResultAttachmentsJob.perform_later(submitter)
+
       submitter.submission.template.account.users.active.each do |user|
         SubmitterMailer.completed_email(submitter, user).deliver_later!
       end