adjust migration

app/jobs/process_submitter_completion_job.rb

@@ -6,8 +6,6 @@ class ProcessSubmitterCompletionJob
   def perform(params = {})
     submitter = Submitter.find(params['submitter_id'])
 
-    create_completed_submitter!(submitter)
-
     is_all_completed = !submitter.submission.submitters.exists?(completed_at: nil)
 
     if !is_all_completed && submitter.submission.submitters_order_preserved?
@@ -26,31 +24,36 @@ class ProcessSubmitterCompletionJob
       enqueue_completed_emails(submitter)
     end
 
-    create_completed_documents!(submitter)
+    create_completed_submitter!(submitter)
 
     enqueue_completed_webhooks(submitter, is_all_completed:)
   end
 
   def create_completed_submitter!(submitter)
+    completed_submitter = CompletedSubmitter.find_or_initialize_by(submitter_id: submitter.id)
+
+    return completed_submitter if completed_submitter.persisted?
+
     submission = submitter.submission
-    sms_count = submitter.submission_events.where(event_type: %w[send_sms send_2fa_sms]).count
-    completed_submitter = CompletedSubmitter.where(submitter_id: submitter.id).first_or_initialize
+
     completed_submitter.assign_attributes(
       submission_id: submitter.submission_id,
       account_id: submission.account_id,
       template_id: submission.template_id,
       source: submission.source,
-      sms_count:,
+      sms_count: submitter.submission_events.where(event_type: %w[send_sms send_2fa_sms]).count,
       completed_at: submitter.completed_at
     )
 
-    completed_submitter.save!
-  end
+    submitter.documents.each do |attachment|
+      next if attachment.metadata['sha256'].blank?
 
-  def create_completed_documents!(submitter)
-    submitter.documents.map { |s| s.metadata['sha256'] }.compact_blank.each do |sha256|
-      CompletedDocument.where(submitter_id: submitter.id, sha256:).first_or_create!
+      completed_submitter.completed_documents << CompletedDocument.new(sha256: attachment.metadata['sha256'])
     end
+
+    completed_submitter.save!
+
+    completed_submitter
   end
 
   def enqueue_completed_webhooks(submitter, is_all_completed: false)

app/models/completed_document.rb

@@ -17,4 +17,6 @@
 #
 class CompletedDocument < ApplicationRecord
   belongs_to :submitter
+
+  has_one :completed_submitter, primary_key: :submitter_id, inverse_of: :completed_documents, dependent: :destroy
 end

app/models/completed_submitter.rb

@@ -17,11 +17,17 @@
 #
 # Indexes
 #
-#  index_completed_submitters_on_account_id  (account_id)
+#  index_completed_submitters_on_account_id    (account_id)
+#  index_completed_submitters_on_submitter_id  (submitter_id)
 #
 class CompletedSubmitter < ApplicationRecord
   belongs_to :submitter
   belongs_to :submission
   belongs_to :account
   belongs_to :template
+
+  has_many :completed_documents, dependent: :destroy,
+                                 primary_key: :submitter_id,
+                                 foreign_key: :submitter_id,
+                                 inverse_of: :submitter
 end